| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | wangsh(dot)fnst(at)fujitsu(dot)com, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: can we add some file(msvc) to gitignore |
| Date: | 2021-09-27 11:50:39 |
| Message-ID: | 943F5368-7380-4C6C-B175-1A163F54B4E6@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Sep 2021, at 02:34, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> I don't think that we should remove the entries that track
> files we could expect based on the state of the build code, though,
> like config.pl or buildenv.pl in src/tools/msvc/ as committing those
> could silently break builds.
Agreed, those clearly belong in the .gitignore. The ones I was looking at were
*.vcproj and *.vcxproj in the root .gitignore, but I don't know the MSVC build
well enough to know if those make sense or not.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2021-09-27 11:59:22 | Re: Table AM and DROP TABLE [ Was: Table AM and DDLs] |
| Previous Message | vignesh C | 2021-09-27 11:43:55 | Re: Column Filtering in Logical Replication |