Re: [PATCH v1] eliminate duplicate code in table.c

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Junwang Zhao <zhjwpku(at)gmail(dot)com>
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-21 14:05:30
Message-ID: CAJ7c6TNRdh+dhwMahUrTOkYeZ=RBEqrmFWWvgp5dLTnAFp0qLA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit,

> Yeah, that's better. On again thinking about the function name, I
> wonder if validate_relation_type() suits here as there is no generic
> object being passed?

Yep, validate_relation_type() sounds better.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v5-0001-Eliminate-duplicate-code-in-table.c.patch application/octet-stream 4.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2022-07-21 14:12:29 Re: Make name optional in CREATE STATISTICS
Previous Message Bruce Momjian 2022-07-21 13:48:18 Re: System catalog documentation chapter