| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Erik Nordström <erik(at)timescale(dot)com>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: Feedback on table expansion hook (including patch) |
| Date: | 2021-05-11 12:29:45 |
| Message-ID: | CAJ7c6TNPT87qKFx=wQQRwr4xQt6newH+m2WpB66_fZiKYaW0Ag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Erik,
> Thank you all for the feedback and insights.
>
> Yes, the intention is to *replace* expand_inherited_rtentry() in the same way planner_hook replaces standard_planner().
This patch probably doesn't need yet another reviewer, but since there
is a little controversy about if the hook should replace a procedure
or be called after it, I decided to put my two cents in. The proposed
approach is very flexible - it allows to modify the arguments, the
result, to completely replace the procedure, etc. I don't think that
calling a hook after the procedure was called (or before) will be very
useful.
The patch applies to `master` branch (6d177e28) and passes all the
tests on MacOS.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-05-11 12:40:53 | RE: Parallel INSERT SELECT take 2 |
| Previous Message | Bharath Rupireddy | 2021-05-11 12:07:50 | parallel vacuum - few questions on docs, comments and code |