| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Nikita Malakhov <hukutoc(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jacob Champion <jchampion(at)timescale(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: Pluggable toaster |
| Date: | 2022-11-01 21:15:27 |
| Message-ID: | CAJ7c6TNNy3gzfYrsQLgpLLQ64f-dv60iudubD=S_Xm46pS8+8Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Nikita,
> Please don't forget to run `pgindent` before formatting the patches
> with `git format-patch` next time.
There are also some compiler warnings, please see the attachment.
> I'm going to submit a more detailed code review soon.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| warnings.txt | text/plain | 900 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-11-01 21:31:04 | Re: doc: Fix description of how the default user name is chosen |
| Previous Message | Peter Eisentraut | 2022-11-01 21:00:27 | Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local |