Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Hi Nathan,

> [...]
> I think we should also figure out what we want to do for things like this:
>
> ******************************************************************************
> - This file contains routines that can be bound to a Postgres backend and
> - called by the backend in the process of processing queries. The calling
> - format for these routines is dictated by Postgres architecture.
> + * This file contains routines that can be bound to a Postgres backend and
> + * called by the backend in the process of processing queries. The calling
> + * format for these routines is dictated by Postgres architecture.
> ******************************************************************************/
>
> Could we modify the patch to leave these kinds of comments alone?

I see 3 files that have this comment:

- src/tutorial/complex.c
- contrib/seg/seg.c
- contrib/cube/cube.c

Note that cube.c is not affected by the new version of pgindent,
because the comment starts with `/****`. Such comments are kept as is.

seg.c and cube.c use a mixed format. The comments start with `/*`
followed by ` *` lines but several lines below don't have ` *` in the
beginning. I don't instantly see a way to process this situation in
pgindent. We can either let it modify these comments, or alternatively
change the first lines of the comments from `/*` to `/**`.

--
Best regards,
Aleksander Alekseev