Re: [PATCH] Add tests for src/backend/nodes/extensible.c

Jan, Michael,

Many thanks for all the great feedback! I applied all refactorings
except for the following.

> - Much better for me: add_int_reloption() to force a custom scan to
> return a number of rows you want with a CREATE TABLE .. WITH
> (repeat_count = N). That's doable once the library is loaded, and
> that should be a few extra lines of code. So let's add the reloption
> to control the scans rather than hardcoding it.

Perhaps I'm not fully understand the proposal but it doesn't seem to
work. Particularly after `git apply test.txt` I get:

```
TRAP: failed Assert("numoptions <= num_relopt_elems"), File:
"../src/backend/access/common/reloptions.c", Line: 2246, PID: 2077291
```

... in postmaster.log for a regular CREATE TABLE without the options.
Maybe you could clarify?

> - GUC to force a new per-query repeat_count.

Done this way.

--
Best regards,
Aleksander Alekseev