Re: PATCH: add "--config-file=" option to pg_rewind

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Gunnar Nick Bluth <gunnar(dot)bluth(at)pro-open(dot)de>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PATCH: add "--config-file=" option to pg_rewind
Date: 2022-02-24 09:02:54
Message-ID: CAJ7c6TMVqtzdB+xX2CJOtPcbsBz_3ryhpR3LL7Oa5DwXxEwMUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Gunnar,

> During a Patroni PR discussion
> (https://github.com/zalando/patroni/pull/2225) we realised that if one
> wants to use the "-c" option on a typical Debian/Ubuntu installation
> (where the config resides below /etc/postgresql/), pg_rewind needs a way
> to be told where the postgresql.conf actually is.
>
> The attached patch implements this as an option.
>
> [...]

Good catch!

Could you also implement a TAP test for the new code?

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2022-02-24 09:16:52 Re: Proposal: Support custom authentication methods using hooks
Previous Message Aleksander Alekseev 2022-02-24 08:56:36 Re: Support logical replication of DDLs