| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Refactor *_abbrev_convert() functions |
| Date: | 2026-07-03 08:57:42 |
| Message-ID: | CAJ7c6TMJvw=Z791j4Ky=1VxykfbvGS8cDVnNSCia=MFfe5BhCQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi John,
Thanks for the feedback!
> This seems like it belongs in 0002.
> Also, when a hunk is changed to a single line, we should remove the
> parens. I see three like this.
Fixed.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Simplify-abbreviated-key-hashing-using-murmurhash.patch | text/x-patch | 4.2 KB |
| v6-0002-Avoid-unnecessary-type-casting-when-using-hash_an.patch | text/x-patch | 9.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-07-03 09:03:24 | Re: Re-read subscription state after lock in AlterSubscription |
| Previous Message | Akshay Joshi | 2026-07-03 08:47:25 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |