| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Remove unused PageIsPredicateLocked() |
| Date: | 2026-09-16 13:23:02 |
| Message-ID: | CAJ7c6TMCOi-TTfPSWh+wxkOMgqcvoG-FCWPU1iGCfrmA2JOajQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The proposed patch removes dead code in src/backend/storage/lmgr/predicate.c
If my understanding is correct, PageIsPredicateLocked() was added in
dafaa3efb75 (Feb 2011) but its call was removed in 47ad79122bc (Mar
2011) and we have never used it since. It was mentioned in one recent
discussion [1] but it was pointed out that it can't be used there
either.
If anyone believes that we should keep it alternatively we could cover
it with tests or at least add an Assert() somewhere.
[1]: http://postgr.es/m/CA%2BCOZaBo%2BZpKgMvxcdACUjNtdYipe9Em06iX5KHLTVaTmFibiw%40mail.gmail.com
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-unused-PageIsPredicateLocked.patch | text/x-patch | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-09-16 13:36:51 | Re: 64-bit MultiXactOffset vs. 9.3->9.4 upgrade, pg_resetwal, "wraparound" msg |
| Previous Message | Manuel Reyes Bravo | 2026-09-16 13:20:45 | Add a test for index_rebuild_count of REPACK (CONCURRENTLY) |