| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Remove unused PageIsPredicateLocked() |
| Date: | 2026-09-16 14:22:52 |
| Message-ID: | CAEze2WgC11g5Ob6s4Vpj+EQsEHRHC5_6m9MZaPLjVg6X9C2Ubg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 16 Sept 2026 at 15:23, Aleksander Alekseev
<aleksander(at)tigerdata(dot)com> wrote:
>
> Hi,
>
> The proposed patch removes dead code in src/backend/storage/lmgr/predicate.c
>
> If my understanding is correct, PageIsPredicateLocked() was added in
> dafaa3efb75 (Feb 2011) but its call was removed in 47ad79122bc (Mar
> 2011) and we have never used it since. It was mentioned in one recent
> discussion [1] but it was pointed out that it can't be used there
> either.
>
> If anyone believes that we should keep it alternatively we could cover
> it with tests or at least add an Assert() somewhere.
I'm fine with removing it, for reasons including because its signature
promise wasn't ever truly clear.
-Matthias
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-09-16 14:26:53 | Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts |
| Previous Message | Tom Lane | 2026-09-16 14:20:57 | Re: POC: Carefully exposing information without authentication |