| From: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera from 2ndQuadrant <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |
| Date: | 2019-09-14 15:05:25 |
| Message-ID: | CAJ3gD9fBMFwrDpLWpQpJDnJObAd+npBFqYKL4VV22G--YLmTPA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 13 Sep 2019 at 22:01, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Sep 13, 2019 at 12:14 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Again, though, the advice that's been given here is that we should
> > fix logical decoding to use the VFD API as it stands, not change
> > that API. I concur with that.
>
> A reasonable position. So I guess logical decoding has to track the
> file position itself, but perhaps use the VFD layer for managing FD
> pooling.
Yeah, something like the attached patch. I think this tracking of
offsets would have been cleaner if we add in-built support in VFD. But
yeah, for bank branches at least, we need to handle it outside of VFD.
Or may be we would add it if we find one more use-case.
--
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company
| Attachment | Content-Type | Size |
|---|---|---|
| use_vfd_for_logrep.patch | application/octet-stream | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-09-14 15:08:06 | Re: [PATCH] Improve performance of NOTIFY over many databases (v2) |
| Previous Message | Daniel Verite | 2019-09-14 13:51:03 | Re: Create collation reporting the ICU locale display name |