| From: | davinder singh <davindersingh2692(at)gmail(dot)com> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Date: | 2020-04-08 07:02:51 |
| Message-ID: | CAHzhFSHudQRufGzH3KmjMxxQqTEPsewf-4Dck29fEuKw6QAkcw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 7, 2020 at 8:30 PM Juan José Santamaría Flecha <
juanjo(dot)santamaria(at)gmail(dot)com> wrote:
>
> * The logic on "defined(_MSC_VER) && (_MSC_VER >= 1900)" is defined as
> "_WIN32_WINNT >= 0x0600" on other parts of the code. I would
> recommend using the later.
>
I think "_WIN32_WINNT >= 0x0600" represents windows versions only and
doesn't include any information about Visual Studio versions. So I am
sticking to " defined(_MSC_VER) && (_MSC_VER >= 1900)".
I have resolved other comments. I have attached a new version of the patch.
--
Regards,
Davinder.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-PG-compilation-error-with-VS-2015-2017-2019.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-04-08 07:04:09 | Re: pg_stat_statements issue with parallel maintenance (Was Re: WAL usage calculation patch) |
| Previous Message | wenjing | 2020-04-08 07:00:20 | Re: [bug] Wrong bool value parameter |