| From: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add memory/disk usage for Function Scan nodes in EXPLAIN |
| Date: | 2026-10-01 12:07:11 |
| Message-ID: | CAHza6qcZbCqX0LNcHYpOUdoj=wgddHwpz+QaN4pr3X9qBD_trQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi David,
Thank you for the review!
> Can you prepare an initial patch that swaps tuplestore_end() for
> tuplestore_clear() in the relevant locations (similar to what
> 908a96861 did). This can go in separately on the justification that
> it's an optimisation to avoid the reallocation of fields that are
> pfree'd in tuplestore_end().
Sure! Happy to work on this. I'll prepare a separate patch and
post it once it's ready.
> I'll look at doing this for nodeMaterial.c. It might be somewhat
> harder to get a plan with a parameterised Material node, however, but
> it should be possible.
I noticed you've already posted the nodeMaterial.c patch [1], so I'll
use it as a reference.
Regards,
Tatsuya Kawata
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2026-10-01 12:12:25 | Re: Fix apply worker crash when subscriber table has only a deferrable primary key |
| Previous Message | Amit Langote | 2026-10-01 12:05:20 | Re: Revert RI fast-path batching from REL_19_STABLE |