Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work

From: Shubham Khanna <khannashubham1197(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work
Date: 2023-12-26 10:10:36
Message-ID: CAHv8RjLJ36mPv-hadPqF_Xj51AY5csy6MSBLebrS921OnQgeHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 26, 2023 at 3:02 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> Hi hacker,
>
> As $subject detailed, the tab-complete cannot work such as:
>
> CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
>
> It seems that the get_previous_words() could not parse the single quote.
>
> OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
>
I reviewed the Patch and it looks fine to me.

Thanks and Regards,
Shubham Khanna.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-12-26 10:10:41 Re: Show WAL write and fsync stats in pg_stat_io
Previous Message Amit Kapila 2023-12-26 10:05:02 Re: Synchronizing slots from primary to standby