| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-03-10 07:08:34 |
| Message-ID: | CAHv8RjK85NwNkP9WMOm1dzepJ02NgApPOPgADvqfSL7MS6yqZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 10, 2025 at 10:28 AM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> On Thu, Mar 6, 2025 at 9:18 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> > + Subscription names, publication names, and replication slot names are
> > + automatically generated. Cannot be used together with
> > + <option>--database</option>, <option>--publication</option>,
> > + <option>--replication-slot</option> or <option>--subscription</option>.
> >
> > Don't start the sentence with "Cannot". Change the sentence to "This
> > option cannot be used together with ..."
> > similar sentences used in 3 other places below this as well. Change all of them.
>
> I didn't find any instance of "Cannot be" in the *.sgml files, but I
> find some instances of "Can be". So it seems we allow such constructs
> in the documentation. Any reasons for suggesting this change?
>
> --
Updated the .sgml file accordingly. The attached patch at [1] contains
the required changes.
Thanks and regards,
Shubham Khanna.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2025-03-10 07:09:04 | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Previous Message | Mats Kindahl | 2025-03-10 07:08:09 | Re: Coccinelle for PostgreSQL development [1/N]: coccicheck.py |