From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
---|---|
To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Assorted typo fixes |
Date: | 2024-01-02 10:21:22 |
Message-ID: | CAHv8Rj+nVkRXSDxMpwhqn9MLmUSb9u0mNNJ69KHagLZxzuF2rg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 2, 2024 at 4:35 AM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
>
> Shubham Khanna <khannashubham1197(at)gmail(dot)com> writes:
>
> > I was reviewing the Patch and came across a minor issue that the Patch
> > does not apply on the current Head. Please provide the updated version
> > of the patch.
>
> Thanks for the heads-up. Commit 5ccb3bb13dcbedc30d015fc06d306d5106701e16
> removed one of the instances of "data struture" fixed by the patch.
>
> Rebased patch set attached. I also squashed the check_decls.m4 change
> into the main comment typos commit.
>
> > Also, I found one typo:
> > 0008-ecpg-fix-typo-in-get_dtype-return-value-for-ECPGd_co.patch All
> > the other enum values return a string mathing the enum label, but this
> > has had a trailing r since the function was added in commit
> > 339a5bbfb17ecd171ebe076c5bf016c4e66e2c0a
> >
> > Here 'mathing' should be 'matching'.
>
> Thanks. I've fixed the commit message (and elaborated it a bit more why
> I think it's a valid and safe fix).
I have reviewed the Rebased version of the Patch and it looks fine to me.
Thanks and Regards,
Shubham Khanna.
Attachment | Content-Type | Size |
---|---|---|
image.png | image/png | 322.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2024-01-02 10:25:11 | Re: Commitfest manager January 2024 |
Previous Message | Magnus Hagander | 2024-01-02 10:12:50 | Re: Commitfest manager January 2024 |