| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add support for specifying tables in pg_createsubscriber. |
| Date: | 2025-11-03 04:40:38 |
| Message-ID: | CAHv8Rj+dC5-Rayo7CHu=-rZHgi1UUeUBTJD6LwT4PAb=m-8QGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 13, 2025 at 11:15 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham.
>
> The log output looks OK now. So, I don't have any more review comments
> for this thread.
>
> Meanwhile, please watch my other pending patches [1][2] re
> pg_createsubscriber logging. If those get pushed first, then your
> patch will probably need rebasing.
>
> ======
> [1] dropall - https://www.postgresql.org/message-id/flat/CAHut%2BPtm%2BWJwbbYXhC0s6FP_98KzZCR%3D5CPu8F8N5uV8P7BpqA%40mail.gmail.com
> [2] dryrun - https://www.postgresql.org/message-id/CAHut%2BPsvQJQnQO0KT0S2oegenkvJ8FUuY-QS5syyqmT24R2xFQ%40mail.gmail.com
>
Hi Peter,
I noticed that your logging patch from [1] has now been committed.
Accordingly, I have rebased my patch at [2] to align with the updated
dry-run and drop-all logging behavior. Please find the rebased version
attached.
[1] - https://www.postgresql.org/message-id/CAHut+PsvQJQnQO0KT0S2oegenkvJ8FUuY-QS5syyqmT24R2xFQ@mail.gmail.com
[2] - https://www.postgresql.org/message-id/CAHv8Rj%2BSTAopLQVRp9K%2BWvse5P0qb9w99nPBQxzK5hXzPVi0aw%40mail.gmail.com
Thanks and regards,
Shubham Khanna.
| Attachment | Content-Type | Size |
|---|---|---|
| v17-0001-Support-existing-publications-in-pg_createsubscr.patch | application/octet-stream | 12.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-11-03 05:26:42 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | Xuneng Zhou | 2025-11-03 02:20:28 | Re: Implement waiting for wal lsn replay: reloaded |