Re: [HACKERS] logical decoding of two-phase transactions

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-03-30 00:03:59
Message-ID: CAHut+Pv7575kTOm6R4kexVE8sG=Qsu=VuxHp45soJ7N+W2b_nA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Please find attached the latest patch set v68*

Differences from v67* are:

* Rebased to HEAD @ today.

* v68 fixes an issue reported by Vignesh [1] where a scenario was
found which still was able to cause a generated GID clash. Using
Vignesh's test script I could reproduce the problem exactly as
described. The fix makes the GID unique by including the subid. Now
the same script runs to normal completion and produces good/expected
output:

transaction | gid | prepared |
owner | database
-------------+------------------+-------------------------------+----------+----------
547 | pg_gid_16389_543 | 2021-03-30 10:32:36.87207+11 |
postgres | postgres
555 | pg_gid_16390_543 | 2021-03-30 10:32:48.087771+11 |
postgres | postgres
(2 rows)

----
[1] https://www.postgresql.org/message-id/CALDaNm2ZnJeG23bE%2BgEOQEmXo8N%2Bfs2g4%3DxuH2u6nNcX0s9Jjg%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v68-0001-Add-support-for-prepared-transactions-to-built-i.patch application/octet-stream 107.5 KB
v68-0002-Support-2PC-txn-subscriber-tests.patch application/octet-stream 21.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2021-03-30 00:29:46 Re: TRUNCATE on foreign table
Previous Message Thomas Munro 2021-03-29 23:54:11 Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.