| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: GUC values - recommended way to declare the C variables? |
| Date: | 2022-10-25 06:11:12 |
| Message-ID: | CAHut+PtJEiVZ5XpZk+7NARjuY0Xn=ESSspJ7eAwvs-MfmQHNdA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 25, 2022 at 4:09 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Oct 25, 2022 at 02:43:43PM +1100, Peter Smith wrote:
> > This is essentially the same as before except now, utilizing the
> > GUC_DEFAULT_COMPILE flag added by Justin's patch [1], the sanity-check
> > skips over any dynamic compiler-dependent GUCs.
>
> Yeah, this is a self-reminder that I should try to look at what's on
> the other thread.
>
> > Patch 0001 - GUC trivial mods to logical replication GUC C var declarations
>
> This one seems fine, so done.
> --
Thanks for pushing v3-0001.
PSA v4. Rebased the remaining 2 patches so the cfbot can still work.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-TMP-Justins-DYNAMIC_DEFAULT-patch.patch | application/octet-stream | 12.9 KB |
| v4-0002-GUC-C-variable-sanity-check.patch | application/octet-stream | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-10-25 06:25:32 | Re: fixing typo in comment for restriction_is_or_clause |
| Previous Message | Japin Li | 2022-10-25 05:40:23 | Re: fixing typo in comment for restriction_is_or_clause |