| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fixing typo in comment for restriction_is_or_clause |
| Date: | 2022-10-25 06:25:32 |
| Message-ID: | CAFBsxsE8VdeN_++LzZORaLRfc4Rea-aOiQsmvQyEsD2TygvD_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 25, 2022 at 9:48 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
>
> On Tue, Oct 25, 2022 at 10:05 AM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
wrote:
>>
>> It's perfectly clear and simple now, even if it doesn't win at "code
golf".
>
>
> Agree with your point. Do you think we can further make the one-line
> function a macro or an inline function in the .h file? I think this
> function is called quite frequently during planning, so maybe doing that
> would bring a little bit of efficiency.
My point was misunderstood, which is: I don't think we need to do anything
at all here if the goal was purely about aesthetics.
If the goal has now changed to efficiency, I have no opinion about that yet
since no evidence has been presented.
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-10-25 06:28:06 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Peter Smith | 2022-10-25 06:11:12 | Re: GUC values - recommended way to declare the C variables? |