Re: [HACKERS] logical decoding of two-phase transactions

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-03-24 07:32:50
Message-ID: CAHut+PsqftiDBWZu6Xq4ZCUxq+ZbA1FrqE_3N5hh_ZA1Rir=qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 23, 2021 at 9:01 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Tue, Mar 23, 2021 at 10:44 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Mon, Mar 22, 2021 at 11:51 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > I have incorporated all your changes and additionally made few more
> > > changes (a) got rid of LogicalRepBeginPrepareData and instead used
> > > LogicalRepPreparedTxnData, (b) made a number of changes in comments
> > > and docs, (c) ran pgindent, (d) modified tests to use standard
> > > wait_for_catch function and removed few tests to reduce the time and
> > > to keep regression tests reliable.
> >
> > I checked all v65* / v66* differences and found only two trivial comment typos.
> >
> > PSA patches to fix those.
> >
>
> Hi Amit.
>
> PSA a patch to allow the ALTER SUBSCRIPTION ... REFRESH PUBLICATION to
> work when two-phase tristate is PENDING.
>
> This is necessary for the pg_dump/pg_restore scenario, or for any
> other use-case where the subscription might
> start off having no tables.
>
> Please apply this on top of your v66-0001 (after applying the other
> Feedback patches I posted earlier today).
>

PSA a small addition to the 66-0003 "Fix to allow REFRESH PUBLICATION"
patch posted yesterday.

This just updates the worker.c comment.

------
Kind Regards,
Peter Smith.
Fujitsu Australia.

Attachment Content-Type Size
v66-0004-Updated-worker.c-comment.patch application/octet-stream 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2021-03-24 07:42:30 Re: pl/pgsql feature request: shorthand for argument and local variable references
Previous Message tanghy.fnst@fujitsu.com 2021-03-24 07:31:18 RE: Logical Replication vs. 2PC