Re: create subscription - improved warning message

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: create subscription - improved warning message
Date: 2022-10-10 09:27:30
Message-ID: CAHut+Psnb3Xkf8BUBi_Wf7TAaXj+JvPRnyByjQS7GsDvOQ07vg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 10, 2022 at 4:04 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Oct 10, 2022 at 10:10 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
...
> The docs say [1]: "When creating a subscription, the remote host is
> not reachable or in an unclear state. In that case, the subscription
> can be created using the connect = false option. The remote host will
> then not be contacted at all. This is what pg_dump uses. The remote
> replication slot will then have to be created manually before the
> subscription can be activated."
>
> I think the below gives accurate information:
> WARNING: subscription was created, but is not connected
> HINT: You should create the slot manually, enable the subscription,
> and run %s to initiate replication.
>

+1

PSA patch v2 worded like that.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v2-0001-create-subscription-warning-message.patch application/octet-stream 10.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-10-10 09:34:15 src/test/perl/PostgreSQL/Test/*.pm not installed
Previous Message Dilip Kumar 2022-10-10 09:16:17 Re: problems with making relfilenodes 56-bits