| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2022-09-20 02:22:40 |
| Message-ID: | CAHut+PvzAR7eXOMeF1eZy3_zjJ5UQJZgRWmT7Y52v=8yJTRJ1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I had quick look at the latest v11-0001 patch differences from v10.
Here are some initial comments:
======
1. Commit message
It looks like some small mistake happened. You wrote [1] that my
previous review comments about the commit message were fixed, but it
seems the v11 commit message is unchanged since v10.
======
2. src/backend/replication/logical/relation.c -
GenerateDummySelectPlannerInfoForRelation
+/*
+ * This is not a generic function, helper function for
+ * GetCheapestReplicaIdentityFullPath. The function creates
+ * a dummy PlannerInfo for the given relationId as if the
+ * relation is queried with SELECT command.
+ */
+static PlannerInfo *
+GenerateDummySelectPlannerInfoForRelation(Oid relationId)
"generic function, helper function" -> "generic function. It is a
helper function"
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-20 02:29:15 | Re: Proposal to use JSON for Postgres Parser format |
| Previous Message | Andres Freund | 2022-09-20 02:16:30 | Re: [RFC] building postgres with meson - v13 |