Re: Some deleted GUCs are still referred to

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Some deleted GUCs are still referred to
Date: 2023-11-13 23:32:16
Message-ID: CAHut+PviACF++p2+ktzsm_+VZgagVZpnrv2kBC7Kb7+EzAmKSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-translators

On Thu, Nov 9, 2023 at 8:12 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 9 Nov 2023, at 00:51, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > I happened to notice that some GUC names "max_fsm_pages" and
> > "max_fsm_relations" are still mentioned in these translation files
> > (from the REL_16_1 source zip)
> >
> > src\backend\po\fr.po
> > src\backend\po\tr.po
> >
> > ~~
> >
> > Should those be removed?
>
> These mentions are only in comments and not in actual translations, so I don't
> think they risk causing any issues.
>
> $ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l
> 0
>
> I don't know enough about the translation workflow to know how these comments
> are handled, sending this to pgsql-translators@ might be a better way to reach
> the authors working on this.
>

Thanks for the advice. Done that.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-11-13 23:35:28 Re: archive modules loose ends
Previous Message Peter Smith 2023-11-13 23:19:50 Re: add log messages when replication slots become active and inactive (was Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?)

Browse pgsql-translators by date

  From Date Subject
Next Message Peter Smith 2023-11-15 01:20:10 Fwd: Some deleted GUCs are still referred to
Previous Message Daniel Gustafsson 2023-11-09 09:12:03 Re: Some deleted GUCs are still referred to