| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in tablesync comment |
| Date: | 2021-02-03 07:52:56 |
| Message-ID: | CAHut+PvhkiiEOjW8LpgF8oTHPfaA5L=Fu6zym1Vs6=V2W2UtcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 3, 2021 at 6:13 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Feb 02, 2021 at 07:23:37PM +0530, Amit Kapila wrote:
> > I don't mind changing to your proposed text but I think the current
> > wording is also okay and seems clear to me.
>
> Reading that again, I still find the word "transient" to be misleading
> in this context. Any extra opinions?
OTOH I thought "additionally stored" made it seem like those states
were in the catalog and "additionally" in shared memory.
Maybe better to rewrite it more drastically?
e.g
-----
* The catalog pg_subscription_rel is used to keep information about
* subscribed tables and their state. The catalog holds all states
* except SYNCWAIT and CATCHUP which are only in shared memory.
-----
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2021-02-03 07:58:00 | Re: Single transaction in the tablesync worker? |
| Previous Message | Tom Lane | 2021-02-03 07:30:26 | Re: Printing backtrace of postgres processes |