| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal - function string_to_table |
| Date: | 2020-08-25 09:18:26 |
| Message-ID: | CAHut+Pvd2DoJ8d+YvyT-KL9-ss++0KMa4kh1stNdtmuD5=mMzA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 25, 2020 at 4:58 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> When you run ./unused_oids script, then you get this message
>
> [pavel(at)nemesis catalog]$ ./unused_oids
<snip>
> Patches should use a more-or-less consecutive range of OIDs.
> Best practice is to start with a random choice in the range 8000-9999.
> Suggested random unused OID: 8973 (1027 consecutive OID(s) available starting here)
>
> For me, this is simple protection against oid collision under development, and I expect so commiters does oid' space defragmentation.
I have not used that tool before. Thanks for teaching me!
===
I have re-checked the string_to_table_20200825.patch.
Everything looks good to me now, so I am marking this as "ready for committer".
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-08-25 09:22:44 | Re: proposal - function string_to_table |
| Previous Message | Jakub Wartak | 2020-08-25 09:16:03 | Re: Handing off SLRU fsyncs to the checkpointer |