Re: Update Examples in Logical Replication Docs

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Update Examples in Logical Replication Docs
Date: 2025-07-22 02:15:18
Message-ID: CAHut+PvVuM-RbL=JOT-0d2dfc1TJEgGvO7ekkUOfvZ8+5J0MEg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 22, 2025 at 3:27 AM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> Hi,
>
> While going through the example for column lists [1] and row filters
> [2] in logical replication, I found that the output of "\dRp+" is not
> updated as per PostgreSQL 18. In PG 18, a new column "Generated
> columns' was added in "\dRp+" by commit [3], so I think we should
> update the docs to reflect the same. I have attached a patch with the
> changes.
> The changes apply to both the branches REL_18_STABLE and HEAD.
>

Good catch. The patch LGTM (by inspection only -- I did not try it).

Note there is a typo in the commit message:
/Defination/Definition/

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-07-22 02:17:42 Re: teach pg_upgrade to handle in-place tablespaces
Previous Message Nathan Bossart 2025-07-22 02:06:59 Re: teach pg_upgrade to handle in-place tablespaces