Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE PUBLICATION with 'publish_generated_columns' parameter specified but unassigned
Date: 2025-08-04 08:44:45
Message-ID: CAHut+PvThD-=rLHWOr2CC4hQ+Upc5+=7Rwt2_f-F5NkNY6EvrQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 4, 2025 at 4:37 PM David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Sunday, August 3, 2025, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>>
>> Recently, I learned it is possible to say:
>>
>> CREATE PUBLICATION pub ... WITH (publish_generated_columns);
>>
>> This is equivalent to:
>> CREATE PUBLICATION pub ... WITH (publish_generated_columns = stored);
>>
>>
>> What is the verdict for this syntax -- ok or not?
>
>
> Not.
>
> An enum should not allow for an omitted value. The documented policy of only booleans being allowed an optional value is what is expected. I’d say this is a new-in-18 bug that should be fixed in the code. The documentation is correct - absence of the option means “none”, presence requires an explicit value and not its own missing-value default.
>

Thanks. That is the same as my understanding.

I will post a patch to do this tomorrow.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-08-04 08:57:49 Re: Add backup_type to pg_stat_progress_basebackup
Previous Message Chao Li 2025-08-04 08:17:43 Re: Raw parse tree is not dumped to log