| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - ALTER PUBLICATION - description has confusing slash-list |
| Date: | 2026-08-13 11:03:58 |
| Message-ID: | CAHut+PvSFnPjFe7WsO5PNeHBTAK94rxD+9cPdertb3vnKh3Tmw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 13, 2026 at 11:11 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Tue, Aug 11, 2026 at 1:20 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Wed, Aug 5, 2026 at 2:06 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > I noticed that the Description section of the ALTER PUBLICATION page
> > > [1] has a poorly worded sentence:
> > >
> > > "Note that adding tables/except tables/schemas to a publication that
> > > is already subscribed to will require an ALTER SUBSCRIPTION ...
> > > REFRESH PUBLICATION action"
> > >
> > > The problem is due to that strange slash-list. Apart from being
> > > difficult to read, it makes it sound as if there's a distinct object
> > > called an "except table", when what's meant is "changing a
> > > publication's EXCEPT list."
> > >
> > > PSA patch v1 to reword this using plain English.
> > >
> >
> > LGTM. minot nitpic: "...publication. Note", here instead of two
> > spaces, let's use one space to be consistent with the nearby doc
> > wording. Also, this needs to be backpatched to 19, see if applied and
> > build cleanly on 19 as well.
> >
>
> Thanks for checking the patch. I've modified it as suggested, to
> remove the extra space.
>
> I also confirmed that it applies/builds cleanly on PG_REL19_STABLE.
>
> ~
>
> PSA patch v2.
>
I saw this was already pushed. Thanks for pushing.
I've flagged the CF entry as "committed".
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-08-13 11:11:06 | Re: Allow table AMs to define their own reloptions |
| Previous Message | Daniel Gustafsson | 2026-08-13 11:01:49 | Re: [PATCH] Remove dead code in pgcrypto |