| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: logical decoding and replication of sequences, take 2 |
| Date: | 2023-11-30 01:47:51 |
| Message-ID: | CAHut+PvQnLa6Wu+LYhApw7Zfvj+R9UzOyD_YbbG9bQ-h_d6MDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 29, 2023 at 11:45 PM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
>
>
> On 11/27/23 23:06, Peter Smith wrote:
> > FWIW, here are some more minor review comments for v20231127-3-0001
> >
> > ======
> > .../replication/logical/reorderbuffer.c
> >
> > 3.
> > + * To decide if a sequence change is transactional, we maintain a hash
> > + * table of relfilenodes created in each (sub)transactions, along with
> > + * the XID of the (sub)transaction that created the relfilenode. The
> > + * entries from substransactions are copied to the top-level transaction
> > + * to make checks cheaper. The hash table gets cleaned up when the
> > + * transaction completes (commit/abort).
> >
> > /substransactions/subtransactions/
> >
>
> Will fix.
FYI - I think this typo still exists in the patch v20231128-0001.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-11-30 01:52:23 | Re: about help message for new pg_dump's --filter option |
| Previous Message | Kyotaro Horiguchi | 2023-11-30 01:39:00 | Extra periods in pg_dump messages |