Re: [HACKERS] logical decoding of two-phase transactions

On Mon, Mar 8, 2021 at 4:58 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> LOGICAL_REP_MSG_TYPE = 'Y',
> + LOGICAL_REP_MSG_BEGIN_PREPARE = 'b',
> + LOGICAL_REP_MSG_PREPARE = 'P',
> + LOGICAL_REP_MSG_COMMIT_PREPARED = 'K',
> + LOGICAL_REP_MSG_ROLLBACK_PREPARED = 'r',
> LOGICAL_REP_MSG_STREAM_START = 'S',
> LOGICAL_REP_MSG_STREAM_END = 'E',
> LOGICAL_REP_MSG_STREAM_COMMIT = 'c',
> - LOGICAL_REP_MSG_STREAM_ABORT = 'A'
> + LOGICAL_REP_MSG_STREAM_ABORT = 'A',
> + LOGICAL_REP_MSG_STREAM_PREPARE = 'p'
> } LogicalRepMsgType;
> As we start adding more and more features, we will have to start
> adding more message types, using meaningful characters might become
> difficult. Should we start using numeric instead for the new feature
> getting added?

This may or may not become a problem sometime in the future, but I
think the feedback is not really specific to the current patch set so
I am skipping it at this time.

If you want, maybe create it as a separate thread, Is it OK?

----
Kind Regards,
Peter Smith.
Fujitsu Australia