Re: Should we say "wal_level = logical" instead of "wal_level >= logical"

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Should we say "wal_level = logical" instead of "wal_level >= logical"
Date: 2025-10-21 23:19:12
Message-ID: CAHut+PvP2kut4mh3jppymooPnozow3T2fEtybERy3u_kbB1a3A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 21, 2025 at 2:11 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Oct 20, 2025 at 3:20 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > Do you have thoughts about the patch?
>
> I agree with the rationale that Ashutosh states but I don't see a
> strong need to patch the code to make this a 100% invariable rule. (Of
> course, someone else may disagree, which is fine.)
>

In case it makes any difference...

The codebase already follows this rule in 95% of cases. The patch
simply corrects a couple of inconsistencies that appeared to be
accidental oversights.

======
Kind Regards,
Peter Smith
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2025-10-22 00:02:08 Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
Previous Message Matheus Alcantara 2025-10-21 23:16:49 Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue