| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-05-26 06:28:43 |
| Message-ID: | CAHut+PvB3rUs2ccUxJ1q1YEmvtHN3HJGSEjT4Cbc=5pjoGO9Yg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh.
I had only one trivial review comment for v40-0001/0002 combined.
======
src/backend/commands/subscriptioncmds.c
1.
+ if (OidIsValid(subconflictlogrelid))
+ {
+ ObjectAddress object;
+ char *conflictrelname;
+
+ /* Drop any dependent conflict log table */
+ conflictrelname = get_rel_name(subconflictlogrelid);
That "Drop any..." comment doesn't have anything to do with the
statement that follows it. I think this comment belongs outside the
if.
e.g.
/* Drop any dependent conflict log table */
if (OidIsValid(subconflictlogrelid))
{
...
}
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2026-05-26 06:51:41 | Re: POC: PLpgSQL FOREACH IN JSON ARRAY |
| Previous Message | Chao Li | 2026-05-26 06:27:34 | Re: Fix bug of CHECK constraint enforceability recursion |