Re: Documentation improvement patch

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Oleg <o(dot)sibiryakov(at)postgrespro(dot)ru>
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Documentation improvement patch
Date: 2026-10-11 21:41:33
Message-ID: CAHut+Pv2r8osdv90mOJYhvWjc_de9YuihX7h6oE1hR6KofeCpw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Hi,

I had a look at the parts that were related to logical replication.

Everything seemed "correct" to me, but the patch makes just bare
minimal changes for single words or commas. That's OK if minimal
changes is the objective, but there are some places where you might
consider going further and fixing awkward sentences properly given you
are changing them anyway. e.g.

Current:
The ADD TABLES IN SCHEMA, SET TABLES IN SCHEMA, SET ALL TABLES, and
SET ALL SEQUENCES to a publication requires the invoking user to be a
superuser.

Patched ("requires" -> "require"):
The ADD TABLES IN SCHEMA, SET TABLES IN SCHEMA, SET ALL TABLES, and
SET ALL SEQUENCES to a publication require the invoking user to be a
superuser.

Suggested:
The invoking user must be a superuser to use ADD TABLES IN SCHEMA, SET
TABLES IN SCHEMA, SET ALL TABLES, or SET ALL SEQUENCES.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-docs by date

  From Date Subject
Previous Message Laurenz Albe 2026-10-11 13:54:03 Re: Table 9.46. UUID Extraction Functions