| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-06-15 08:58:50 |
| Message-ID: | CAHut+PuzngVKsmQHTuzj_3Xzefc4jkUAcUS81Gms0GajucA+iA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Some review comments for v50-0004.
======
src/bin/pg_dump/pg_dump.c
dumpSubscription:
1.
+ * We skip the default value ('log') to match the handling of other
+ * default subscription options.
+ */
There is only one "default", so I think this should say "...other
subscription options", not "...other default subscription options".
======
src/include/catalog/pg_subscription.h
2.
+#define CONFLICT_LOG_RELATION_NAME_FMT "pg_conflict_log_%u"
+
2a.
This format string (and first usage of it) really be in one of the
earlier patches.
~
2b.
Add a comment to explain that the %u is the subscription oid.
~
2c.
Is this the correct header file for this? IMO it is CLT specific, so
belongs in conflict.h.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-06-15 08:59:41 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Akshay Joshi | 2026-06-15 08:55:06 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |