Re: Fix some newly modified tab-complete changes

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix some newly modified tab-complete changes
Date: 2022-10-18 06:17:32
Message-ID: CAHut+PuX9RfH+0-c3J=Gby83GSmHef93itqRf=ENuv6KHNxTzg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 11, 2022 at 1:28 AM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Mon, Oct 10, 2022 2:12 PM shiy(dot)fnst(at)fujitsu(dot)com <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > On Tue, Oct 4, 2022 4:17 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > But, while testing I noticed another different quirk
> > >
> > > It seems that neither the GRANT nor the REVOKE auto-complete
> > > recognises the optional PRIVILEGE keyword
> > >
> > > e.g. GRANT ALL <tab> --> ON (but not PRIVILEGE)
> > > e.g. GRANT ALL PRIV<tab> --> ???
> > >
> > > e.g. REVOKE ALL <tab> --> ON (but not PRIVILEGE)..
> > > e.g. REVOKE ALL PRIV<tab> --> ???
> > >
> >
> > I tried to add tab-completion for it. Pleases see attached updated patch.
> >

Hi Shi-san,

I re-tested and confirm that the patch does indeed fix the quirk I'd
previously reported.

But, looking at the patch code, I don't know if it is the best way to
fix the problem or not. Someone with more experience of the
tab-complete module can judge that.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-10-18 06:31:07 Simplify standby state machine a bit in WaitForWALToBecomeAvailable()
Previous Message Bharath Rupireddy 2022-10-18 06:16:27 CF Bot failure in wait_for_subscription_sync()