| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Date: | 2026-08-05 01:18:55 |
| Message-ID: | CAHut+PuMvpk-R1uv9dTiiLvDGfKuYBm1KaZP8+5xFNzxY9h8Pg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Some review comments for v25*.
======
//////////
Patch v25-0001
//////////
======
Commit Message
1.
- EXCEPT is supported only with FOR TABLES IN SCHEMA, not FOR TABLE.
~
I think you can remove this first note. It seems redundant because
it's already clear (from the supported syntax etc) that this patch has
nothing to do with FOR TABLE. Anyway, saying "EXCEPT is supported only
with FOR TABLES IN SCHEMA" ignores the already-existing functionality
of FOR ALL TABLES EXCEPT, so it could be misleading.
//////////
Patch v25-0004
//////////
1.
+ <para>
+ Replace the schema list of <structname>sales_publication</structname> with
+ <structname>sales</structname>, excluding only
+ <structname>sales.drafts</structname>. All other previously excluded tables
+ in schema <structname>sales</structname> are no longer excluded. Any schemas
+ previously in <structname>sales_publication</structname> are removed:
+<programlisting>
+ALTER PUBLICATION sales_publication SET TABLES IN SCHEMA sales EXCEPT
(TABLE drafts);
+</programlisting>
+ </para>
IMO the word "Replace" already tells it's going to overwrite
everything that may have been there previously, so the current
explanation seemed unnecessarily verbose.
SUGGESTION
Replace the schema list of <structname>sales_publication</structname>
with only schema <structname>sales</structname>, excluding only
<structname>sales.drafts</structname>.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-08-05 01:27:11 | Re: MERGE/SPLIT PARTITIONS issues/questions |
| Previous Message | Richard Guo | 2026-08-05 01:18:21 | Re: Prove a NOT IN's left-hand expressions non-nullable from quals |