Re: possible typo for CREATE PUBLICATION description

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: possible typo for CREATE PUBLICATION description
Date: 2022-10-13 07:26:16
Message-ID: CAHut+Pu9bw9nWAB5c4M3WpF-h8z7bupO4ByAu=T_JHPELdG-7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 13, 2022 at 6:16 PM osumi(dot)takamichi(at)fujitsu(dot)com
<osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
>
> Hi,
>
>
> I noticed a possible typo in the doc for create publication.
> This applies to PG15 as well.
> Kindly have a look at the attached patch for it.
>
>

Your typo correction LGTM.

FWIW, maybe other parts of that paragraph can be tidied too. e.g. The
words "actually" and "So" didn't seem needed IMO.

~

BEFORE
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that actually results from the command. So depending on
the outcome, it may be published as either INSERT or UPDATE, or it may
not be published at all.

SUGGESTION
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that results from the command. Depending on the outcome,
it may be published as either INSERT or UPDATE, or it may not be
published at all.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2022-10-13 07:31:45 Re: Pluggable toaster
Previous Message osumi.takamichi@fujitsu.com 2022-10-13 07:16:39 possible typo for CREATE PUBLICATION description