| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_createsubscriber --dry-run logging concerns |
| Date: | 2025-10-09 00:55:55 |
| Message-ID: | CAHut+Pu84M8tgTjn++4WCTETOX=NR4YmLn-+4B29UJeDTgoJ9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 8, 2025 at 9:04 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Oct-08, Peter Smith wrote:
>
> > I am not wedded to doing this double-messaging... if people feel just
> > the one-time logging at the beginning is enough, then that is OK by
> > me.
>
> Some other tools (not Postgres ones) do that and it always makes me
> nervous, because I can never be sure which parts were actually done and
> which parts are only dry-run trials. I'd rather stay away from that
> approach.
>
OK. Here are v2 patches to implement both ways. You can pick one or both.
0001 - a beginning log to say if the tool is in dry-run mode
0002 - alternate pg_log_info messages for pg_createsubscriber, when in
dry-run mode
~
Note: there might be a clash with another thread [1] if that gets
committed soon; I will deal with any rebase if/when it is needed.
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-log-to-say-command-is-executing-in-dry-run-mode.patch | application/octet-stream | 4.7 KB |
| v2-0002-add-different-dry-run-logging-for-pg_createsubscr.patch | application/octet-stream | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-10-09 01:03:34 | Re: another autovacuum scheduling thread |
| Previous Message | Jeremy Schneider | 2025-10-09 00:30:30 | Re: another autovacuum scheduling thread |