From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Improvements in Copy From |
Date: | 2020-08-27 05:32:11 |
Message-ID: | CAHut+Pu3=pnVOfqswg9tEt0CdaLYVRa0QkfHVRjV+n5PeXjfSQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello.
FYI - that patch has conflicts when applied.
Kind Regards
Peter Smith
Fujitsu Australia.
On Thu, Aug 27, 2020 at 3:11 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Tue, Jul 14, 2020 at 12:17 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Tue, Jul 14, 2020 at 11:13 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > >
> > > On Tue, 14 Jul 2020 at 17:22, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > > >
> > > > On Thu, 2 Jul 2020 at 00:46, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > > > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter
> > > > > that is not being used, it can be removed.
> > > >
> > > > This was raised in [1]. We decided not to remove it.
> > >
> > > I just added a comment to the function to mention why we want to keep
> > > the parameter. I hope that will save any wasted time proposing its
> > > removal in the future.
> > >
> > > FWIW, the function is inlined. Removing it will gain us nothing
> > > performance-wise anyway.
> > >
> > > David
> > >
> > > > [1] https://www.postgresql.org/message-id/flat/CAKJS1f-A5aYvPHe10Wy9LjC4RzLsBrya8b2gfuQHFabhwZT_NQ%40mail.gmail.com#3bae9a84be253c527b0e621add0fbaef
> >
> > Thanks David for pointing it out, as this has been discussed and
> > concluded no point in discussing the same thing again. This patch has
> > a couple of other improvements which can still be taken forward. I
> > will remove this change and post a new patch to retain the other
> > issues that were fixed.
> >
>
> I have removed the changes that david had pointed out and retained the
> remaining changes. Attaching the patch for the same.
> Thoughts?
>
> Regards,
> Vignesh
> EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2020-08-27 05:45:54 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
Previous Message | Ranier Vilela | 2020-08-27 05:00:40 | Clang UndefinedBehaviorSanitize (Postgres14) Detected undefined-behavior |