Re: pg_createsubscriber - more logging to say if there are no pubs to drop

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber - more logging to say if there are no pubs to drop
Date: 2025-10-14 21:18:15
Message-ID: CAHut+Pu2sp3ERnX=PP7rdLXL2KPz_dcd_2OmLXynEMBtTtVvAA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 15, 2025 at 5:49 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Oct 14, 2025 at 10:41 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Wed, Oct 8, 2025 at 6:34 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
...
> > >
> > > Here is a small patch to remove that doubt. Now, if there is nothing
> > > found, the logging would look like:
> > >
> > > ----------
> > > pg_createsubscriber: dropping all existing publications in database "db2"
> > > pg_createsubscriber: no publications found
> > > ----------
> > >
> > > Thoughts?
> >
> > Thank you for the patch!
> >
> > It sounds like a reasonable improvement. I'll push the patch, barring
> > any objections.
>
> Done.
>

Thanks for pushing!

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-10-14 21:19:07 Re: Optimize LISTEN/NOTIFY
Previous Message Philip Alger 2025-10-14 21:14:52 Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement