| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: row filtering for logical replication |
| Date: | 2022-02-24 02:55:54 |
| Message-ID: | CAHut+PtmJkKoQg+bVVKd3ZQ701ku84BkkLW1YEhmmUegYC6M=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 24, 2022 at 1:33 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Feb 24, 2022 at 7:57 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > I noticed that there was a build-farm failure on the machine 'komodoensis' [1]
> >
> > # Failed test 'check replicated rows to tab_rowfilter_toast'
> > # at t/028_row_filter.pl line 687.
> > # got: ''
> > # expected: 't|1'
> > # Looks like you failed 1 test of 20.
> > [18:21:24] t/028_row_filter.pl ................
> > Dubious, test returned 1 (wstat 256, 0x100)
> > Failed 1/20 subtests
> >
> > That failure looks intermittent because from the history you can see
> > the same machine already passed multiple times in this test case.
> >
> > When I investigated the test case I noticed there seems to be a
> > missing "catchup" ($node_publisher->wait_for_catchup($appname);), so
> > sometimes if the replication happens too slowly then the expected row
> > might not be found on the subscriber side.
> >
>
> Your analysis seems correct to me and it is evident from the result as
> well. Reviewing the test, it seems other similar places already have
> the catchup but it is missed after this update test.
>
> > I will post a patch to fix this shortly.
> >
>
> Thanks.
>
PSA a patch to fix the observed [1] build-farm failure.
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-BF-test-fail-caused-by-bad-timing.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KAWAMOTO Masaya | 2022-02-24 02:56:22 | Typo in pgbench messages. |
| Previous Message | osumi.takamichi@fujitsu.com | 2022-02-24 02:44:06 | RE: Optionally automatically disable logical replication subscriptions on error |