| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-08-01 08:02:21 |
| Message-ID: | CAHut+PtinkWsPPA8RN2jWTuhTSYj0sbRT9A7_ZeM0ezKNNSa6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 1, 2022 at 3:27 PM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Fri, Jul 29, 2022 1:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> >
> > Thanks for the comments, the attached v41 patch has the changes for the
> > same.
> >
>
> Thanks for updating the patch.
>
> I wonder in the case that the publisher uses PG15 (or before), subscriber uses
> PG16, should we have this check (check if publication tables were also
> subscribing from other publishers)? In this case, even if origin=none is
> specified, it doesn't work because the publisher doesn't filter the origin. So
> maybe we don't need the check for initial sync. Thoughts?
>
IIUC for the scenario you've described (subscription origin=none and
publisher < PG16) the subscriber can end up getting extra data they
did not want, right?
So instead of just "don't need the check", maybe this combination
should throw ERROR, or at least a log a WARNING?
------
KInd Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-08-01 08:41:48 | Re: Inconvenience of pg_read_binary_file() |
| Previous Message | Kyotaro Horiguchi | 2022-08-01 07:57:44 | Re: Oversight in slab.c SlabContextCreate(), initial memory allocation size is not populated to context->mem_allocated |