Re: Proposal: Conflict log history table for Logical Replication

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-05-26 22:50:23
Message-ID: CAHut+Ptaf=2p4c33jsuz9nJY4=TtfZzFkermAeL5q=krOjMYEw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 26, 2026 at 7:38 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
...
> 1)
> heap_create:
> + errdetail("Conflict schema modifications are currently disallowed.")));
> LookupCreationNamespace:
> + errmsg("cannot move objects into or out of the pg_conflict schema")));
>
> Can we make it same through-out, either we use 'Conflict schema' at
> both the places or pg_conflict schema. Since in these 2 functions, in
> previous messages, we are using names like 'System catalog', 'TOAST
> schema' etc, I think we can use Conflict schema at both the places.
> What do others think on this?
>

The suggested name of "Conflict schema" LGTM. My only concern was that
a user may not know where that is referring to. OTOH, things like
"System catalog" have 100s of mentions and whole documentation
chapters dedicated to them. If we go with "Conflict schema", then the
documentation needs to also consistently use that term, describe what
it is for, and make it very easy to look up and discover that
"Conflict schema" is 'pg_conflict'.

Currently (in patches 0008/9) there is very little explanation even
about what pg_conflict is, apart from just observing in passing that
the CLT gets written to that "dedicated namespace". It seems a bit
backwards describing the parent schema by the contents: Instead of
saying when there is a CLT it gets written there, IMO it should be the
other way around, and say there is a "Conflict schema" which is where
the CLTs (if any) reside.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-05-26 23:04:17 Re: Fix HAVING-to-WHERE pushdown with mismatched operator families
Previous Message SATYANARAYANA NARLAPURAM 2026-05-26 22:49:55 [Patch] Fix check_pub_rdt bypass when origin is set in same ALTER SUBSCRIPTION