| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | surya poondla <suryapoondla4(at)gmail(dot)com> |
| Cc: | Steven Niu <niushiji(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "jiaoshuntian(at)gmail(dot)com" <jiaoshuntian(at)gmail(dot)com>, "nishant(dot)sharma(at)enterprisedb(dot)com" <nishant(dot)sharma(at)enterprisedb(dot)com>, "jim(dot)jones(at)uni-muenster(dot)de" <jim(dot)jones(at)uni-muenster(dot)de> |
| Subject: | Re: PSQL schema "describe" \dn is not escaping quotes |
| Date: | 2026-10-18 22:15:35 |
| Message-ID: | CAHut+PtW==_JHbDNz3LcWWzj2k8-KDWxWXgxbVei6OFmwN+Nqw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 16, 2026 at 10:17 PM surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
>
> Hi Peter,
>
> Thanks for v9. It applies cleanly on master, builds without warnings, and make check passes.
>
> I re-ran my edge cases against it. Names with embedded ', , "" and ., quoted mixed case, the partially quoted "FOO"bar pattern, and a wildcard matching a single schema all show the right footer. The numeric \dn 2200 and the over-long pattern no longer show a footer for the wrong schema. Patterns matching several schemas print the plain list as before. Patterns matching nothing now print just (0 rows); on master, unquoted \dn E_Mixed and the over-long pattern both printed an empty list with the publications of a schema that wasn't listed.
>
> v9 looks good to me.
>
Thank you very much for helping review this patch.
I have marked the CF entry [1] as "ready for committer"
======
[1] https://commitfest.postgresql.org/patch/7066/
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-18 22:37:36 | Re: Revert libpq servicefile connection option in v19 (info leak and uninterruptible backend DoS) |
| Previous Message | Peter Smith | 2026-10-18 22:12:07 | Re: Include schema-qualified names in publication error messages (generalised to all of LR). |