| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix how some lists are displayed by psql \d+ |
| Date: | 2026-01-21 21:08:31 |
| Message-ID: | CAHut+PtSGPwNgUJYA94WC7Osw4us9Dou=7T_RmxZuS1s4LsGDw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 21, 2026 at 7:30 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Jan 21, 2026, at 16:22, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Wed, Jan 21, 2026 at 7:05 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >>
> >>
> >>
> >>> On Jan 21, 2026, at 10:58, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >>>
> >>> A rebase was needed for some more test expected output changes.
> >>>
> >>> PSA v2.
> >>>
> >>> ======
> >>> Kind Regards,
> >>> Peter Smith.
> >>> Fujitsu Australia
> >>> <v2-0002-Fix-to-make-psql-d-lists-of-inherits-look-same-as.patch><v2-0001-Fix-to-make-psql-d-lists-of-partitions-look-same-.patch>
> >>
> >> I still see some difference:
> >> ```
> >> evantest=# \d+ p_test;
> >> Partitioned table "public.p_test"
> >> Column | Type | Collation | Nullable | Default | Storage | Compression | Stats target | Description
> >> ----------+---------+-----------+----------+---------+----------+-------------+--------------+-------------
> >> id | integer | | | | plain | | |
> >> username | text | | | | extended | | |
> >> category | text | | | | extended | | |
> >> Partition key: LIST (category)
> >> Indexes:
> >> "idx_p_test_id" btree (id)
> >> Partitions:
> >> p_test_v1 FOR VALUES IN ('A')
> >> p_test_v2 FOR VALUES IN ('B')
> >> ```
> >>
> >> The index name is quoted, but the partition names are not.
> >>
> >
> > AFAICT
> > Indexes are quoted
> > Constraints are quoted
> > Publications are also quoted
> >
> > Partitions are NOT quoted
> > Inherits are NOT quoted
> >
> > ~
> >
> > Please confirm --- So, you are expecting that Partitions and Child
> > tables should also be quoted, so that everything looks the same?
> >
> > This is scope creep from the original intent of this thread, so I will
> > look at doing this in a separate patch 0003.
> >
> > ======
> > Kind Regards
> > Peter Smith.
> > Fujitsu Australia
>
> Actually I don’t know the rule, which should be quoted and which should not. Is the inconstancy a blocker?
>
> So, I was just pointing out the inconsistency, and I want to hear a clarification from someone.
>
OK. I feel that the "Partitions" and "Child tables" + "Interits" might
be the odd ones out here, just as those were the odd ones out re the
list indentation logic.
But I will hold off on adding quotes for them until I hear some
committer advice that it would be a worthwhile change.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2026-01-21 21:08:37 | Re: Add missing JIT inline pass for llvm>=17 |
| Previous Message | Kirill Reshke | 2026-01-21 21:07:51 | Re: Fix crash during recovery when redo segment is missing |