| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Warn when creating or enabling a subscription with max_logical_replication_workers = 0 |
| Date: | 2026-02-04 06:26:25 |
| Message-ID: | CAHut+Pt5KzE75ZyFZPC2fcb+GRes2DbHAh_vgfdDXoWmEV6hAg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 4, 2026 at 4:07 PM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> Hi,
>
> I would like to propose emitting a warning when creating or enabling a
> subscription while max_logical_replication_workers is set to 0. In this
> case, the CREATE/ALTER SUBSCRIPTION command completes successfully without
> any warning, making it difficult to notice that logical replication cannot
> start.
>
> Of course, users can confirm whether logical replication is working by
> checking system views such as pg_stat_replication or pg_stat_subscription.
> However, emitting warnings explicitly in these cases would make this
> situation more visible. We have seen user reports where this behavior
> caused confusion, with users wondering why replication did not start.
>
Hi Nagata-San.
AFAIK the default for `max_logical_replication_workers` is 4. So how
does the maximum get to be 0 unless the user had explicitly configured
it that way?
Also subscriptions require multiple workers in order to work properly
[1] so why check only 0? Why not check 1 or 2 or 3.... those low
numbers are also likely to cause similar problems aren't they?
And what about when the `max_logical_replication_workers` is 100, but
those 100 are already being used. IOW, would it be more useful to warn
when you do not have enough *available* workers for the Subscription
to function properly, rather than checking what the maximum value is
set to?
Kind Regards,
Peter Smith
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-02-04 06:27:03 | Re: using index to speedup add not null constraints to a table |
| Previous Message | Michael Paquier | 2026-02-04 06:23:59 | Re: Add expressions to pg_restore_extended_stats() |