| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-05-26 04:59:41 |
| Message-ID: | CAHut+Pt5304yZ8cgDvYWHdzVz1VS44JzSu6L39stpSDbTZSxZw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 26, 2022 at 2:20 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, May 26, 2022 at 7:06 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Here are my review comments for patch v15-0001.
> >
> > ======
> >
> > 1. Commit message
> >
> > Should this also say new test cases were added for the test_decoding plugin?
> >
> > ~~~
>
> Shall we take this out as a separate test-case patch? I think it is a
> good idea to do a missing test case for existing functionality.
>
+1. I also think this new test could be posted separately.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2022-05-26 05:05:10 | Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds |
| Previous Message | Michael Paquier | 2022-05-26 04:27:52 | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |