| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Publication of same parent table with ONLY-ness mismatch should error |
| Date: | 2026-10-19 22:03:58 |
| Message-ID: | CAHut+PsxuNZk4H-oLkx=BD47L4PM0Gp9M_2bdYgN4ceePQnBsw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 19, 2026 at 6:11 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
...
>
> Overall the patch looks good. But with so many 'relids' in play, it
> takes time to figure out what each one represents. Do you think we
> should also add below in the new comment:
>
> /*
> * relids holds every relation added to the result so far, both those the
> * user named and inheritance children added implicitly by recursion. It
> * is used to filter out duplicates.
> *
> * relids_explicit holds only the relations the user actually named (a
> * subset of relids). relids_recursing holds those explicitly named
> * relations whose first mention did not specify ONLY. Together they are
> * used to detect conflicting ONLY specifications for the same table.
> */
>
Hi Shveta.
I agree, your suggested code comment looks helpful.
Added it in patch v3. PSA.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Error-if-same-table-has-ONLY-mismatch.patch | application/octet-stream | 12.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-10-19 22:05:05 | Re: [DEPARSE] Pretty-printed sublink test expressions lose needed parentheses |
| Previous Message | David Rowley | 2026-10-19 21:39:51 | Re: regress: query discrepancy between explain vs execution |