| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Manuel Reyes Bravo <manuelreyesbravo(at)gmail(dot)com> |
| Subject: | Re: Distinguish publication exclusions in object addresses |
| Date: | 2026-09-18 02:49:35 |
| Message-ID: | CAHut+PssUw0X0eiN3nEHXy40SKx3vL02Z8Orev-Pcz=fyPpHBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
AFAICT, the patch has traded one kind of quoting problem for another.
Before patch v3, the message might show nested quotes.
After patch v3, the message might show mismatched quotes:
CREATE PUBLICATION testpub9 FOR ALL TABLES EXCEPT (TABLE "schema has
embedded "" quotes"."part has embedded "" quotes");
ERROR: cannot specify relation "schema has embedded " quotes.part has
embedded " quotes" in the publication EXCEPT clause
~
PSA a v3 top-up patch to address the new problem.
Of course, putting my escape_embedded_quotes() function where I did in
the top-up doesn't seem appropriate. It would be better to associate
that with the original RelationGetQualifiedRelationName() and call it
from there, but RelationGetQualifiedRelationName was removed, so...
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| PS_topup_fix_v3.diff | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 王红岩 | 2026-09-18 02:50:47 | Re: [PATCH v2] Optimize 64-bit atomic access on RV64 |
| Previous Message | Bingshuai Li | 2026-09-18 02:19:58 | Re: Bug in logical decoding with DDL and subtransactions |